RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v2]

[Tejesh R]

On Thu, 25 Apr 2024 10:21:57 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> Default time out may not be sufficient to test, can be increased.

@kumarabhi006 I've updated the test with column selection too for testing purpose.

> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 198:
> 
>> 196:         final String WINDOWS_SPECIFIC = """
>> 197:                 Tab, Shift-Tab - Navigate In.
>> 198:                 Return/Shift-Return - move focus one cell down/up.
> 
> Suggestion:
> 
>                 Return/Shift-Return - Move focus one cell down/up.
> 
> For consistency please ensure each command action to start with either lower case or upper case. Same for F2, Esc commands etc.
> 
> Check for Linux and Mac specific instructions also.

Yes, I've updated all instructions to start with Upper Case.

> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 217:
> 
>> 215:                 F2 - Allows editing in a cell containing information without
>> 216:                      overwriting the information
>> 217:                 Esc -  Resets the cell content back to the state it was in
> 
> Suggestion:
> 
>                 Esc -  Reset the cell content back to the state it was in.
> 
> 
> Minor suggestion,  end with `.` for each statement else nothing.

None of the statements are ending with `.`, I'll leave it that way.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18855#issuecomment-2090014751
PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1587337563
PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1587338476