RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v70]

Magnus Ihse Bursie ihse at openjdk.org
Thu May 2 11:08:25 UTC 2024


On Wed, 3 Apr 2024 02:38:21 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Bumping
>
>> @TheShermanTanker I tried to help you get this done. I added fixes to a copy of your branch on my personal fork, but then it turned out I could not push them to your branch. :-(
>> 
>> It ended up with me creating a new PR, #18584. As a bonus, I think it might be easier to review with a fresh start. This PR has grown quite heavy with lots of comments and commits.
>> 
>> I hope you don't feel like I'm stealing this away from you. You have done a great job, and shown a lot of patience of carrying this all the way here. But I also got the impression that you would appreciate my assistance in getting the last pieces in place so we can integrate this.
> 
> Not at all, I don't feel like you're stealing this from me. In fact, I should be the one apologising for giving you extra work! Thanks for taking this up, I once again apologise for making you do this instead, I've been very busy since Thursday (working on OpenJDK while in lectures at times), and during my breaks I've been too drained to continue, so i really appreciate your help :)
> 
> I will keep this open until the other Pull Request has been integrated, in case this might still be needed

@TheShermanTanker You can close this PR. The bug was fixed with https://github.com/openjdk/jdk/pull/18584 instead.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2090226777


More information about the client-libs-dev mailing list