RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions [v6]

Alexander Zvegintsev azvegint at openjdk.org
Thu May 2 13:07:54 UTC 2024


On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> For the following manual test, more instructions are added as to what to expect for "hide,iconify and show" vs "hide,iconify,show and restore" for clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java line 117:

> 115:                 .instructions(INSTRUCTIONS)
> 116:                 .testTimeOut(10)
> 117:                 .rows(26)

Suggestion:

                .rows(27)

It doesn't fit on Linux without scrolling:
![image](https://github.com/openjdk/jdk/assets/77687766/61dbce3a-5065-42e0-b36b-4446630ce2af)

(the test is problem listed on Linux, but we can fix it now to avoid coming back to it later)

-------------

PR Review: https://git.openjdk.org/jdk/pull/19008#pullrequestreview-2035689784
PR Review Comment: https://git.openjdk.org/jdk/pull/19008#discussion_r1587602609


More information about the client-libs-dev mailing list