RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v13]

[Tejesh R]

On Fri, 3 May 2024 03:31:22 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JTabbedPane's content area, tab area and tab background color are not as expected when opaque is set to true or false. 
>> The proposed fix is to handle the TabbedPane's background color in installed LAFs. Manual test is added to support the fix and there is no regression caused by the fix. 
>> 
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>> 
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unselected tab background property added

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 653:

> 651: 
> 652:         if (isSelected) {
> 653:             g.setColor( selectColor );

Suggestion:

            g.setColor(selectColor);

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56:

> 54:     private static JTabbedPane tabPane;
> 55:     private static final String INSTRUCTIONS = """
> 56:             The background color of panel (which contains the tabbed pane is green).

Can you reframe this sentence because it doesn't mention about the color, except you have mentioned in braces.

test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 125:

> 123:         tabPane.setTabLayoutPolicy(JTabbedPane.SCROLL_TAB_LAYOUT);
> 124:         tabPane.setTabPlacement(JTabbedPane.TOP);
> 125:         PassFailJFrame.addTestWindow(frame);

Is it required to add `frame` explicitly to PassFailJFrame here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588652353
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588659139
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588657505