RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]
Phil Race
prr at openjdk.org
Wed May 8 15:49:55 UTC 2024
On Mon, 6 May 2024 18:06:18 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Change 'Page Setup' to 'Appearance' tab in the OutputBinAttributePrintDialogTest
>
> I added the `OutputBin` class and package-info.java changes to the CSR `javax.print: Support IPP output-bin attribute extension` description: https://bugs.openjdk.org/browse/JDK-8331601
>
> The `OutputBin` class has two `myStringTable` and `myEnumValueTable` tables. They are private but their values are accessed through the public API. Should `myStringTable` and `myEnumValueTable` tables be mentioned in the CSR?
>
> Should the changes in the common print dialog (the output bin label and the output bin combo-box) and new properties from the `serviceui.properties` be described in the CSR?
@AlexanderScherbatiy did you see the comment in the CSR about sealed classes ?
I had originally suggested in this PR (search for a comment from a while ago) and I don't know if you saw it there either.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2100882772
More information about the client-libs-dev
mailing list