RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed [v2]

Damon Nguyen dnguyen at openjdk.org
Wed May 8 19:20:52 UTC 2024


On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   button1_down_mask, dispose on edt, replace system err with out, frame srcpoint and dimension access on edt

LGTM. Just add a newline for separation after the test tags.

test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java line 53:

> 51:  * @run main MouseEventAfterStartDragTest
> 52:  */
> 53: public final class MouseEventAfterStartDragTest implements AWTEventListener {

Suggestion:

 */
 
public final class MouseEventAfterStartDragTest implements AWTEventListener {

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19128#pullrequestreview-2046464818
PR Review Comment: https://git.openjdk.org/jdk/pull/19128#discussion_r1594520774


More information about the client-libs-dev mailing list