RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]
Phil Race
prr at openjdk.org
Thu May 9 19:30:53 UTC 2024
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code restructuring. Moved all page loading calls inside synchronize to make it thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>
> Rearranged if based on suggesion
Changes seem fine, but I would like to hear how this was tested ?
And if there is a specific test that exists for this, or why one could not be created.
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18670#pullrequestreview-2048663406
More information about the client-libs-dev
mailing list