RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v3]

[Harshitha Onkar]

On Thu, 2 May 2024 09:36:18 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Instructions set has been updated as per OS specific. JTable keyboard navigation is tested in each OS and according it's current implementation the instructions has been updated (Few has been removed and few has been updated). 
>> PassFailJFrame.builder is used.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix + Eanbled column selection mode

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 182:

> 180:                 2. Check all combinations of navigational keys in all four modes
> 181:                   shift and control verifying each change to the selection against
> 182:                   the spec. If it does, press "pass", otherwise press "fail".

"...in all four modes shift and control verifying each change to the selection against the spec." 
Can this sentence be rephrased for clarity ?

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 191:

> 189:                 .rows(11)
> 190:                 .columns(50)
> 191:                 .testUI(KeyBoardNavigation::initTest)

Default timeout of 5 mins is less to go through the test instructions. You might want to increase by adding .testTimeOut().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1596259643
PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1596256419