RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v3]

Harshitha Onkar honkar at openjdk.org
Fri May 10 05:11:05 UTC 2024


On Tue, 23 Apr 2024 07:27:02 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 190:
>> 
>>> 188:         PassFailJFrame.builder()
>>> 189:                 .instructions(INSTRUCTIONS)
>>> 190:                 .rows(11)
>> 
>> Suggestion:
>> 
>>                 .rows((int) INSTRUCTIONS.lines().count() + 2)
>> 
>> 
>> This is what we used for our tests. I default to using this now myself.
>
> This doesn't work here since the Instruction rows are quite more.

@TejeshR13 Rows can be increased so as to reduce scrolling.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1596257583


More information about the client-libs-dev mailing list