RFR: 8332103: Add missing `@since` tags to `java.desktop`
Nizar Benalla
duke at openjdk.org
Tue May 14 23:49:01 UTC 2024
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla <duke at openjdk.org> wrote:
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a long time so the default constructor (without parameters) didn't exist until JDK 16
>
> For the `package-info` files, it is pretty hard to find source code of JDK 1-5 so I used the `grep` command to find the oldest instance of an `@since` in those packages.
>
> I found instances of `@since 1.1` in the other packages but `javax/swing/plaf/synth/package-info.java` might be worth checking as most classes there had no `@since`.
As I'm using the historical data built into `javac` to determine the correct `@since` tag to be used, I can only check code added after JDK 9.
So a lot of errors in "older" code will go unnoticed, but I can make sure new tags are correct.
When an `@since` is missing from an element added in newer JDK releases I get an accurate error message i.e
> method: void javax.swing.JSlider.AccessibleJSlider.stateChanged(javax.swing.event.ChangeEvent): `@since` version is 9 instead of 16
but for older code you can only guess "Element: X existed before JDK 10"
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19192#issuecomment-2111335875
More information about the client-libs-dev
mailing list