RFR: 8331746: Create a test to verify that the cmm id is not ignored [v2]
Alexey Ivanov
aivanov at openjdk.org
Wed May 15 10:41:16 UTC 2024
On Tue, 14 May 2024 19:12:25 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and verify that the cmm id of the icc profile is properly reported. Before JDK-8321489 we always report 'lcms' as a cmm id.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>
> Update CustomCMMID.java
test/jdk/java/awt/color/ICC_Profile/CustomCMMID.java line 60:
> 58: byte[] header = p.getData(ICC_Profile.icSigHead);
> 59: byte[] id = new byte[4];
> 60: System.arraycopy(header, ICC_Profile.icHdrCmmId, id, 0, 4);
Does it make sense to use a constant `ID_LENGTH` instead of 4?
The calls to arraycopy could use `JAVA_ID.length` and `id.length` correspondingly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19110#discussion_r1601392726
More information about the client-libs-dev
mailing list