RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri May 17 07:29:14 UTC 2024


On Thu, 16 May 2024 08:48:30 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Revert back the product fix and update test to skip GTK L&F
>  - Merge
>  - separate method to get LAF defined color
>  - extended fix for disabled checkbox and radiobutton
>  - Headful tag revert back and condition check for nimbus
>  - jtreg tag headful removed
>  - JLable foreground color fix for GTK LAF

test/jdk/ProblemList.txt line 673:

> 671: javax/swing/dnd/8139050/NativeErrorsInTableDnD.java 8202765  macosx-all,linux-all
> 672: javax/swing/JEditorPane/6917744/bug6917744.java 8213124 macosx-all
> 673: javax/swing/JRadioButton/4314194/bug4314194.java 8298153 linux-all

8298153 needs to be closed then if this test is going to be deproblemlisted or add that JBS issue in this PR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1604470176


More information about the client-libs-dev mailing list