RFR: 8307193: Several Swing jtreg tests use class.forName on L&F classes

[Abhishek Kumar]

On Wed, 22 May 2024 05:28:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource couple RTL tests

Few minor formatting changes else verified the test and it looks good to me.

test/jdk/javax/swing/JMenuBar/RightLeftOrientation.java line 30:

> 28:  *     ComponentOrientation property is set to RIGHT_TO_LEFT.  This test is
> 29:  *     manual.  The tester is asked to compare left-to-right and
> 30:  *     right-to-left menu bars and judge whether they are mirror images of each

Suggestion:

 *     ComponentOrientation property is set to RIGHT_TO_LEFT. This test is
 *     manual. The tester is asked to compare left-to-right and
 *     right-to-left menu bars and judge whether they are mirror images of each

test/jdk/javax/swing/JMenuBar/RightLeftOrientation.java line 102:

> 100: 
> 101:         frame.add(panel);
> 102: 

Blank lines can be removed.

test/jdk/javax/swing/JToolBar/RightLeftOrientation.java line 29:

> 27:  *     This test checks if tool bars lay out correctly when their
> 28:  *     ComponentOrientation property is set to RIGHT_TO_LEFT.  This test is
> 29:  *     manual.  The tester is asked to compare left-to-right and

Suggestion:

 *     ComponentOrientation property is set to RIGHT_TO_LEFT. This test is
 *     manual. The tester is asked to compare left-to-right and

test/jdk/javax/swing/JToolBar/RightLeftOrientation.java line 107:

> 105: 
> 106:         frame.add(panel);
> 107: 

Blank lines can be removed.

test/jdk/javax/swing/JToolBar/RightLeftOrientation.java line 113:

> 111:         contentPane.setLayout(new BorderLayout());
> 112:         panel = new JPanel();
> 113:         panel.setBackground( Color.white );

Suggestion:

        panel.setBackground(Color.white);

test/jdk/javax/swing/JToolBar/RightLeftOrientation.java line 125:

> 123:         contentPane.setLayout(new BorderLayout());
> 124:         panel = new JPanel();
> 125:         panel.setBackground( Color.white );

Suggestion:

        panel.setBackground(Color.white);

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19341#pullrequestreview-2070161021
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609306846
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609305788
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609306317
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609304630
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609309911
PR Review Comment: https://git.openjdk.org/jdk/pull/19341#discussion_r1609310248