RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v12]
Alexander Scherbatiy
alexsch at openjdk.org
Thu May 23 05:10:07 UTC 2024
On Wed, 22 May 2024 23:29:55 GMT, Alisen Chung <achung at openjdk.org> wrote:
> If output bins are not supported, should the output bin combobox still show up with a single output bin as the only option?
There was a difference between number of output bins reported by cups and and the `PrintService.isAttributeCategorySupported(OutputBin.class)` method which used ipp to check supported categories on MacOS.
It has been fixed that if number of supported output bins by cups is zero the `PrintService.isAttributeCategorySupported(OutputBin.class)` returns false.
Now the output bin combobox is disabled and shows no output bins if the `PrintService.isAttributeCategorySupported(OutputBin.class)` returns false (and number of supported output bins is zero) and just shows one disabled output bin if `PrintService.isAttributeCategorySupported(OutputBin.class)` returns true and there is only one supported output bin (as there are no output bins to select).
> test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 25:
>
>> 23: */
>> 24:
>> 25: /*
>
> jtreg test tags should go below the imports
The fix is updated. jtreg test tags are moved below the imports.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2126241908
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1610983204
More information about the client-libs-dev
mailing list