RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

Artem Semenov asemenov at openjdk.org
Thu May 23 12:48:04 UTC 2024


On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Caching children and selected children of the thee on the native level;
>> Caching all children of a specific parent in CAccessibility to enhance recursive children selection algorithm;
>> Removing fix for JDK-8317771 as no longer needed;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced NULL with nil in OutlineAccessibility - functionally it has no effect but it is more uiform and according to the ObjectibeC convention where objects are referred as nil and references to the primitives as NULL.

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/OutlineAccessibility.m line 141:

> 139:     [super postSelectedCellsChanged];
> 140: }
> 141: 

It seems to me that it is also worth defining a destructor that will destroy the cache before destroying the instance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19255#discussion_r1611630584


More information about the client-libs-dev mailing list