RFR: 8332416: Add more font selection options to Font2DTest [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri May 24 05:42:02 UTC 2024


On Tue, 21 May 2024 23:08:17 GMT, Phil Race <prr at openjdk.org> wrote:

>> Enhance Font2DTest as follows
>> 
>> - Add main menu Radio Button options so that you select the font to use as either
>> - (1) Font Family  + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>> - (3) List of all fontnames - which can still be adjusted by Style if you want.
>> The default is (1) so nothing looks different except that I updated the UI to use Nimbus instead of Metal.
>> 
>> There's new code to gather these ways of referencing the fonts.
>> Also changes were needed for the "Save/Load" options to include the new UI state and font settings.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8332416

src/demo/share/jfc/Font2DTest/FontPanel.java line 742:

> 740:                 verticalBar.setValues( oldValue, numCharDown, 0, totalNumRows );
> 741:             }
> 742:             if ( totalNumRows <= numCharDown && drawStart == 0) {

Is this check needed now since both if and else condition do the same thing?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19273#discussion_r1612809269


More information about the client-libs-dev mailing list