RFR: 8332416: Add more font selection options to Font2DTest [v3]

[Phil Race]

On Fri, 24 May 2024 05:42:31 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8332416
>
> src/demo/share/jfc/Font2DTest/Font2DTest.java line 1443:
> 
>> 1441:                 });
>> 1442: 
>> 1443:                 f.getContentPane().add( f2dt );
> 
> Since this is new code, we can remove getContentPane which is not needed for add

It isn't "new code". I just moved the block inside invokeAndWait because starting the UI
on the main thread can be a real source of hangs. So these lines are indented more but not new.

> src/demo/share/jfc/Font2DTest/FontPanel.java line 742:
> 
>> 740:                 verticalBar.setValues( oldValue, numCharDown, 0, totalNumRows );
>> 741:             }
>> 742:             if ( totalNumRows <= numCharDown && drawStart == 0) {
> 
> Is this check needed now since both if and else condition do the same thing?

I left it because I might want to re-enable this in the future if / when I figure out why the disabled Nimbus scroll bar just looks like a blank piece of window.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19273#discussion_r1613857371
PR Review Comment: https://git.openjdk.org/jdk/pull/19273#discussion_r1613855182