RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v2]

[Abhishek Kumar]

On Thu, 30 May 2024 06:10:29 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 47:
> 
>> 45:  *          JTextArea, JTextPane, and JEditorPane.
>> 46:  * @library /javax/swing/regtesthelpers
>> 47:  * @build SwingTestHelper
> 
> Should this test be marked only for linux?

Since test was written originally to run in GTK L&F, updated the test to run only on linux machine.

> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 82:
> 
>> 80: 
>> 81:         text = type.newInstance();
>> 82:         if (showText) text.setText(name + "\ndisabled");
> 
> `showText` is never initialized, meaning this condition is never executed. Can be removed?

Updated.

> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 159:
> 
>> 157:     }
>> 158: 
>> 159:     public void onBackgroundThread30() {
> 
> Unused, can be removed?

Actually it is not unused and is run on the background thread to `allow enough time for visual verification`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1620046378
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1620044706
PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1620048723