RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v3]

Abhishek Kumar abhiscxk at openjdk.org
Fri May 31 04:42:03 UTC 2024


On Thu, 30 May 2024 19:59:40 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   background method removed
>
> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136:
> 
>> 134:                 if (refimg.getWidth() != testimg.getWidth() ||
>> 135:                     refimg.getHeight() != testimg.getHeight())
>> 136:                 {
> 
> move bracket to previous line to be consistent

Initially I thought of doing so but in one of the PR it was mentioned that "We generally prefer the { on a new line if the conditional is multi-line" https://github.com/openjdk/jdk/pull/18703#discussion_r1571126135.

So I left like that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1621700494


More information about the client-libs-dev mailing list