RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F [v3]

Alexey Ivanov aivanov at openjdk.org
Fri May 31 20:50:05 UTC 2024


On Fri, 31 May 2024 05:02:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 70:
>> 
>>> 68:                                      Class<? extends JTextComponent> type)
>>> 69:         throws Throwable
>>> 70:     {
>> 
>> I think formatting here looks a little odd, could probably move the bracket onto the same line as `throws Throwable` and shift it over to the right to match `Class<? extends JTextComponent> type)`
>
> Updated.

Previous formatting was less confusing and aligned with Java Coding Style Guidelines.

The parameters to the method are aligned to the opening parenthesis; the `throws` clause is not part of the parameters and it's placed on another line according to rules of wrapping lines (it should've used double-indentation of 8 spaces rather than 4 spaces to indicate a continuation line).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19381#discussion_r1622937272


More information about the client-libs-dev mailing list