RFR: 8343418: Use HashMap instead of Hashtable for CSS.htmlAttrToCssAttrMap

Harshitha Onkar honkar at openjdk.org
Fri Nov 1 07:07:41 UTC 2024


On Thu, 31 Oct 2024 20:41:40 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> @turbanoff Based on your explanation, it sounds reasonable to convert CSS.htmlAttrToCssAttrMap from Hashtable to HashMap since synchronization may not be required.
>> 
>> There are few more Hashtables - `styleConstantToCssMap, htmlValueToCssValueMap, cssValueToInternalValueMap`. Do we consider converting them as well - either to HashMap or ConcurrentHashMap (if thread-safe synchronization is required)?
>
> @honkar-jdk yes. It was my intention to convert them all. I want to go one-by-one to make review easier.

@turbanoff  PR title needs to be updated? PR isn't linked to a JBS issue as of now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21785#issuecomment-2450795365


More information about the client-libs-dev mailing list