RFR: 8342098: Write a test to compare the images [v3]
Phil Race
prr at openjdk.org
Fri Nov 1 22:30:31 UTC 2024
On Thu, 31 Oct 2024 15:56:16 GMT, Naveen Narayanan <duke at openjdk.org> wrote:
>> I meant _using `Util.compareBufferedImages`_ rather than copying the code.
>
> @aivanov-jdk
> Definitely using Util will be simpler and lesser lines of code.
> Then we will be getting a True/False as return value.
> Afraid that we will have less info on pixel, color & coordinates like
> `Captured pixel (fffeff00) at (0, 0) is not equal to real pixel (ffffff00)`
>
> This being an AWT Robot test, should we add a Swing Util dependency as well?
The point of this test seems to be a Basic-Acceptance-Test for Robot screen capture.
As such I think it should NOT borrow code. It should be self-contained.
And with such a purpose should work 100% of the time - so long as colour profiles are set up right.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21524#discussion_r1826346137
More information about the client-libs-dev
mailing list