RFR: 8337287: Update image in javax.swing.text.Document.insert [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Nov 5 17:49:30 UTC 2024


On Sun, 22 Sep 2024 14:47:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>> 
>> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
>> 
>> For reference:
>> 
>> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
>> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>> 
>> As in the case with `remove`, I marked up to classes and members with `{@code}`.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Describe inserting ‘quick’ into text

> > > Does it make sense to add a sentence which describes the image? I added one for `remove` to explain all the `Position`s in the removed area are collapsed.
> > 
> > 
> > I missed this question. Yes, sure.
> 
> I updated the PR with an example, look for “For example, if the document contains the text…”.

@prrace Did you have a chance to look at the updated text? The newly added paragraph starts at [line 482](https://github.com/openjdk/jdk/pull/20376/files#diff-db4af1927b99dc7cdea095238dce3e6060258058feaaf587d3b6848562fc1453R482).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2457811841


More information about the client-libs-dev mailing list