RFR: 8343601: javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04 [v2]

Phil Race prr at openjdk.org
Thu Nov 7 23:07:43 UTC 2024


On Thu, 7 Nov 2024 08:54:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It is seen that javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04 OCI instance. It is seen that test frame is being rendered at top-left of screen instead of at the center, and robot mouseMove is being used to point and click on radiobutton, checkbox etc and linux left dock placement can be a problem with this top-left rendering.
>> 
>> Fix is made to render the frame at the center.
>> Repeated iteration of the test run in 22.04 OCI instance is ok.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Increase timeout

test/jdk/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java line 47:

> 45:  * @bug 8158566 8160879 8160977 8158566
> 46:  * @summary Provide a Swing property which modifies MenuItemUI behaviour
> 47:  * @run main/othervm/timeout=600 CloseOnMouseClickPropertyTest

More than 2 minutes you wrote.
I just ran it on mac and it was about 43 seconds
java CloseOnMouseClickPropertyTest  7.21s user 2.21s system 22% cpu 42.608 total

But 600 seconds is 10 minutes
And when we run these tests on our CI system to be conservative we tell jtreg to use 2X the specified timeout.  If it needs 20 minutes I don't think it is ever going to finish.

I think a timeout specified here of maybe 240 is sufficient.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21896#discussion_r1833481080


More information about the client-libs-dev mailing list