RFR: 6672644: JComboBox still scrolling if switch to another window and return back [v4]

[Damon Nguyen]

On Mon, 11 Nov 2024 13:05:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add space
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java line 1685:
> 
>> 1683:                                 >= trackListener.currentMouseY)
>> 1684:                                     ((Timer)e.getSource()).stop();
>> 1685:                     } else if (getThumbBounds().y <= trackListener.currentMouseY)        {
> 
> GUess you are not changing this block so no need for formatting cleanup in this PR.. infact the "{" are also way off if you had to change...there are other non-touched area like l1593...better to cleanup in separate cleanup..

Makes sense. Was a remnant from when I tried implementing a solution here instead. Reverted the changes in this block.

> test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 43:
> 
>> 41:              popup list. While holding left click, the list should be scrolling
>> 42:              down. Press ALT + TAB while holding down left click to switch
>> 43:              focus to a different window. Focus the test frame again and click
> 
> left click => left click button
> focus to a different window => and release the left click mouse button

Gotcha. Added with a few minor edits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1838520642
PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1838520145