RFR: 8342098: Write a test to compare the images [v8]

Alexey Ivanov aivanov at openjdk.org
Wed Nov 13 14:41:24 UTC 2024


On Wed, 13 Nov 2024 09:48:14 GMT, Naveen Narayanan <duke at openjdk.org> wrote:

>> This testcase checks for the following:
>> 
>> 1. An image is drawn on the screen and a portion of it is captured using a Robot. It is tested by comparing whether the captured image is same as the source image. 
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in MacOS, Linux and Windows. Seen all tests passing.
>
> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342098: Updated review comments

Looks good to me.

I still have concerns over the test failing on Mac when run locally. Could anyone else verify it? How do we deal with it? Do we exclude the test from Mac?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21524#pullrequestreview-2433447433


More information about the client-libs-dev mailing list