RFR: 8339524: Clean up a few ExtendedRobot tests [v3]

Harshitha Onkar honkar at openjdk.org
Thu Nov 14 20:59:14 UTC 2024


On Thu, 14 Nov 2024 19:17:41 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Cleaning up tests building ExtendedRobot that shouldn't be.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update tests

Changes requested by honkar (Reviewer).

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java line 34:

> 32:  * @library /java/awt/patchlib
> 33:  * @build java.desktop/java.awt.Helper
> 34:  * @build ExtendedRobot SystemTrayIconHelper

SystemTrayIconHelper uses ExtendedRobot (robot.glide(), click()) so I think you might still need it for this test if this PR is being integrated before  https://github.com/openjdk/jdk/pull/22044

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java line 55:

> 53:             throw new jtreg.SkippedException("SystemTray not supported on the platform." +
> 54:                     " Marking the test passed.");
> 55:         }

Extra bracket at Ln#60. It is on an unedited line hence added the comment here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20846#pullrequestreview-2437174953
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1842877347
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1842872182


More information about the client-libs-dev mailing list