RFR: 8339524: Clean up a few ExtendedRobot tests [v2]
Harshitha Onkar
honkar at openjdk.org
Thu Nov 14 21:21:48 UTC 2024
On Thu, 14 Nov 2024 19:23:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>>> > I will migrate some ExtendedRobot methods to Robot
>>>
>>> Are you saying you'll add _new public_ methods to `java.awt.Robot`?
>>
>> Yes, I will be adding new public methods to Robot in this PR #20846
>> @aivanov-jdk Can you take another look at these tests?
>
>> > > I will migrate some ExtendedRobot methods to Robot
>> >
>> >
>> > Are you saying you'll add _new public_ methods to `java.awt.Robot`?
>>
>> Yes, I will be adding new public methods to Robot in this PR #20846
>
> You referenced this same PR.
>
> Is it really the intention? What kind of methods are you planning to add to the `Robot` class?
>
> [`Robot`](https://docs.oracle.com/en/java/javase/23/docs/api/java.desktop/java/awt/Robot.html) is a public API, adding new public methods to it requires a CSR.
>
>> @aivanov-jdk Can you take another look at these tests?
>
> I will. If I understand correctly, you updated the PR less than 10 minutes ago.
@aivanov-jdk
> Is it really the intention? What kind of methods are you planning to add to the Robot class?
>
> [Robot](https://docs.oracle.com/en/java/javase/23/docs/api/java.desktop/java/awt/Robot.html) is a public API, adding new public methods to it requires a CSR.
This seems to be the correct PR: https://github.com/openjdk/jdk/pull/22044
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20846#issuecomment-2477426521
More information about the client-libs-dev
mailing list