RFR: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window [v3]

Damon Nguyen dnguyen at openjdk.org
Fri Nov 15 18:18:47 UTC 2024


On Fri, 15 Nov 2024 12:02:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test fails in NimbusL&F as DesktopPane does not have green background as set by the user, which is because, the auto-generated [DesktopPanePainter class](https://github.com/openjdk/jdk/blob/eb40a88f4076360708402454a494907e8c0c845d/src/java.desktop/share/classes/javax/swing/plaf/nimbus/SynthPainterImpl.java#L100-L102) which has pre-coded color values does not honour user-defined color.
>> 
>> Fix is to make sure user-defined DesktopPane background color is honoured and is painted and only auto-generated class for L&F derived colors.
>> CI is ok..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   wildcard

Tested this myself as well. It makes me wonder why the original implementation of this didn't work as expected and why checking for an instance of a UIResource is now needed. Works as expected now.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22057#pullrequestreview-2439334360


More information about the client-libs-dev mailing list