RFR: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Sun Nov 17 06:50:30 UTC 2024


On Fri, 15 Nov 2024 22:40:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> oops. he is right, Kevin you have a mistake
>> 
>> "or else Boolean.parseBoolean("sun.java2d.twp.forcesw");" you mean Boolean.getBoolean(..) !
>> 
>> I think the first change made was to
>> Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forceopt", "false"));
>> and I suggested changing to the simpler Boolean.getBoolean() but I meant as a replacement for BOTH calls.
>> ie to
>> Boolean.getBoolean("sun.java2d.twp.forcesw")
>> I didn't notice the mistake on re-review. I guess I too quickly assumed updates were likely to be corrections.
>
> Yes, I realized that when I reread it. `Boolean.getBoolean("sun.java2d.twp.forcesw")` is what I meant for my second comment.

OK done...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1845308494


More information about the client-libs-dev mailing list