RFR: 8148334: The regression case: java/awt/print/PrinterJob/PrintTextTest.java failed as the printed pages do not match the shown pages [v2]

Daniel Gredler duke at openjdk.org
Mon Nov 18 11:16:09 UTC 2024


On Fri, 15 Nov 2024 22:29:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> @honkar-jdk This is the followup to PR #21716 discussed last week. Do you have time to review and possibly test on Windows or mac? The change looks good for me on Linux.
>
> @gredler  Tested on windows with print to pdf option. I noticed that the "G..y..h..." line is still being printed above instead of below as seen in the following screenshot. (Left one - without changes, center window - test window, Right one- with the fix). 
> 
> If you could attach a similar screenshot of your testing on linux, it would be easier to review.
> 
> <img width="1403" alt="GlyphPrint" src="https://github.com/user-attachments/assets/ce43785e-439b-4d1e-ad48-8fd7101fcb81">

@honkar-jdk Interesting, it looks like this fixes Linux then, but not Windows (although the code change is in the shared `PathGraphics` class). Any idea what Mac looks like on page 8 right now? It looks to me like the Windows screenshot is showing two separate bugs (start position, and then individual glyph advances) -- but that's just a guess.

We may need to create a separate bug in the bug tracker just for Linux page 8 and this PR, since it looks like there are still other issues to be fixed in JDK-8148334.

Linux screenshot:

![linux](https://github.com/user-attachments/assets/61187b29-ce74-497d-a5be-bc6ba1d40e41)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2482735546


More information about the client-libs-dev mailing list