RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

Tejesh R tr at openjdk.org
Tue Nov 19 05:34:20 UTC 2024


On Mon, 18 Nov 2024 17:29:54 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Instructions modified for macosx
>
> test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line 46:
> 
>> 44:                     2. Hover mouse over box-for-text.
>> 45:                        Make sure, that mouse cursor is TextCursor (a.k.a. \"beam\").
>> 46:                     3. Hover mouse over each of components (see item 1), except for box-for-text.
> 
> Some instruction lines overflow due to having not enough columns or the line being too long. Can either increase the column count or break up the lines differently. Looks like the lines that end in `box-for-text` and `pressed` overflow.
> ![image](https://github.com/user-attachments/assets/72882471-50c1-4d68-b80c-e1e79b52d770)

I have updated column count to handle this scenario. It looks fine in my local machine, not sure how come its overflowing.
<img width="346" alt="image" src="https://github.com/user-attachments/assets/2a93c2b0-cecd-4cac-8cac-2183870de28f">

> test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line 50:
> 
>> 48:                     4. Drag mouse (using any mouse button) from box-for-text to every"
>> 49:                        component in item 1, and also outside application window."
>> 50:                        Make sure, that cursor remains TextCursor while mouse button is pressed.
> 
> Suggestion:
> 
>                     4. Drag mouse (using any mouse button) from box-for-text to every
>                        component in item 1, and also outside application window.
>                        Make sure, that cursor remains TextCursor while mouse button is pressed.
> 
> Remove extra quotes.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1847666302
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1847665178


More information about the client-libs-dev mailing list