RFR: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor [v3]

Alisen Chung achung at openjdk.org
Tue Nov 19 19:38:12 UTC 2024


On Fri, 15 Nov 2024 17:45:57 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Change test instructions and drawString to say "Text" instead of "Default" for cursor type. Added instructions to test `setCursor` for the frame as well. Also increased the column count to fit the instructions in linux, as it was mentioned that the instructions didn't fit there.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment again

looks good once whitespaces removed

test/jdk/java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java line 84:

> 82:         j.setContinuousLayout(true);
> 83:         j.setSize(200, 200);
> 84:         

looks like theres some whitespaces here

-------------

Marked as reviewed by achung (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22055#pullrequestreview-2446489122
PR Review Comment: https://git.openjdk.org/jdk/pull/22055#discussion_r1848956061


More information about the client-libs-dev mailing list