RFR: JDK-8344057 : Remove doPrivileged calls from unix platform sources in the java.desktop module [v2]

Andrey Turbanov aturbanov at openjdk.org
Tue Nov 19 19:47:47 UTC 2024


On Tue, 19 Nov 2024 19:36:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Post JEP-486 (Permanently Disable the Security Manager) cleanup.
>> Calls to java.security.AccessController.doPrivileged are obsolete thus removed in this PR.
>> 
>> This PR addresses removal of AccessController.doPrivileged() calls from unix-platform files in the java.desktop module. Any SM related imports that are no longer needed are removed.
>> 
>> This PR is limited to removing doPrivileged() calls and excludes any refactoring, reformatting, or other clean up that is out-of-scope for this fix.
>> 
>> PS: I have explicitly add comments to the changes where a more watchful review is required.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed PrivilegedAction from UnixPrintJob

src/java.desktop/unix/classes/sun/awt/screencast/TokenStorage.java line 306:

> 304: 
> 305:             if (changed) {
> 306:                store(PROPS_PATH, "save tokens");

Suggestion:

                store(PROPS_PATH, "save tokens");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22218#discussion_r1848966182


More information about the client-libs-dev mailing list