RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException [v7]

Tejesh R tr at openjdk.org
Wed Nov 20 05:27:21 UTC 2024


On Wed, 21 Aug 2024 08:39:31 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When a printjob is cancelled midway, `PrinterAbortException `was not thrown in macos. because 
>> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as parameter causing it to fail with NPE and
>> secondly PrinterAbortException was consumed silently when `printLoop` throws any exception
>> which is rectified to throw the PrinterAbortException when encountered..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store if its PrinterAbortException

LGTM.

-------------

Marked as reviewed by tr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20027#pullrequestreview-2447432730


More information about the client-libs-dev mailing list