RFR: 8342870: Errors related to unused code on Windows after 8339120 in accessibility [v3]
Julian Waters
jwaters at openjdk.org
Wed Nov 20 05:41:58 UTC 2024
> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
- Merge branch 'master' into accessibility
- Remove now unused result
- Merge branch 'master' into accessibility
- 8342870
-------------
Changes: https://git.openjdk.org/jdk/pull/21656/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21656&range=02
Stats: 38 lines in 9 files changed: 10 ins; 0 del; 28 mod
Patch: https://git.openjdk.org/jdk/pull/21656.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21656/head:pull/21656
PR: https://git.openjdk.org/jdk/pull/21656
More information about the client-libs-dev
mailing list