RFR: 6672644: JComboBox still scrolling if switch to another window and return back [v6]

Damon Nguyen dnguyen at openjdk.org
Thu Nov 21 16:47:22 UTC 2024


On Thu, 21 Nov 2024 11:20:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   isPressed check and set
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java line 1224:
> 
>> 1222:      * A listener to listen for keyboard focus changes.
>> 1223:      */
>> 1224:     protected class KeyboardFocusListener extends MouseAdapter implements PropertyChangeListener {
> 
> Why do you extends "MouseAdapter" ?
> Is it really needed ?

Looks like an artifact from my other implementations. This isn't required anymore, thanks. Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1852499172


More information about the client-libs-dev mailing list