RFR: JDK-8344303 : Remove usage of URLUtil.getConnectPermission from sun.awt.SunToolkit and sun.awt.image.URLImageSource [v2]
Harshitha Onkar
honkar at openjdk.org
Fri Nov 22 20:08:27 UTC 2024
On Fri, 22 Nov 2024 19:47:53 GMT, Phil Race <prr at openjdk.org> wrote:
>> Will changes **sun/net/util/URLUtil.java** be handled in [JDK-8344180](https://bugs.openjdk.org/browse/JDK-8344180)? Or do we do it here?
>
>> so the jdk/src/java.base/share/classes/sun/net/util/URLUtil.java part can be reverted
>
> true
>
>> will changes to java.base files - URLUtil.java be handled in [JDK-8344180](https://bugs.openjdk.org/browse/JDK-8344180)? Or do we do it here?
>
> If really no other code is using, it then yes, you could do it here but you should ask @dfuch about that since I don't know what is in his mind ..
>
> In the bug report he just wrote "This will allow to remove the method from sun.net.util.URLUtil."
>
> Which could be interpreted either way.
@prrace @azvegint There is no other code using it, the awt.sun files were the only two that were using URLUtil.getConnectPermission().
@dfuch I can delete the unused methods in sun/net/util/URLUtil.java and add [JDK-8344180](https://bugs.openjdk.org/browse/JDK-8344180) as additional issue to this PR and handle it all-together. Please let me know if the above works or if you want to handle URLUtil.java changes separately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22330#discussion_r1854585302
More information about the client-libs-dev
mailing list