RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

Damon Nguyen dnguyen at openjdk.org
Fri Nov 22 22:02:15 UTC 2024


On Fri, 22 Nov 2024 18:54:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Usually an empty newline at the end is used.
>
> If I get @DamonGuy correctly, all the files are supposed to end with a blank line, more accurately with `\n` LF character. If the file doesn't, Git and `diff` display a warning ‘no line break’.
> 
> The `HoveringAndDraggingTest.java` file correctly ends with one blank line.

Yes, this is what I meant. I guess when I opened the test on my end when testing, it showed differently. It came up when we were mass converting tests. Thought it was occurring here too.

Quickly looking for an example, there's https://github.com/openjdk/jdk/pull/21196 which was initially missing EOF newlines as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1854777542


More information about the client-libs-dev mailing list