RFR: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
Damon Nguyen
dnguyen at openjdk.org
Mon Nov 25 23:32:42 UTC 2024
On Wed, 18 Sep 2024 13:23:32 GMT, Sharath TN <duke at openjdk.org> wrote:
> Fixed test and fix is working fine.
>
> Fix
> testUI(DefaultCloseOperation::createUI) will create PassfailJFrame test windows when test starts.
>
> PassFailJFrame.addTestWindow(testFrame);
> PassFailJFrame.addTestWindow(testDialog);
>
> Above code exists in the Test. So TestFrame and TestDailog windows will be created when testUI(DefaultCloseOperation::createUI) invoked.
>
> Need to remove above code as this code is not required.
Yeah, there's two ways to go about this. One is to adjust the test instructions. Two is to just remove the frame and dialogue at startup. This is probably best.
You still need a sponsor from a Reviewer.
-------------
Marked as reviewed by dnguyen (Committer).
PR Review: https://git.openjdk.org/jdk/pull/21061#pullrequestreview-2459831442
More information about the client-libs-dev
mailing list