RFR: JDK-8344654 : Some client tests still expect a SecurityManager after JEP486 [v2]

Alexander Zvegintsev azvegint at openjdk.org
Tue Nov 26 02:16:41 UTC 2024


On Tue, 26 Nov 2024 01:48:20 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Post JEP486 test cleanup.
>> 
>> javax/swing/UIDefaults/6795356/bug6795356.java - Deleted as the test is related to ProtectionDomain.
>> 
>> Rest of the tests are updated.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deleted UIDefaults/6795356/bug6795356.java

LGTM, except few minor things:

1.

`test/jdk/lib/client/ExtendedRobot.java` has some `doPrivileged` usage in comment:


//TODO: uncomment three lines below after moving functionality to java.awt.Robot
//{
//    syncDelay = AccessController.doPrivileged(new GetIntegerAction("java.awt.robotdelay", DEFAULT_SYNC_DELAY));
//}


You may want to merge master first, as it is was [modified](https://github.com/openjdk/jdk/pull/22350/files#diff-d609740234c53f16f27b7737255e40496609ec83f8967abf7d25aa47b3a7e0b4) recently. 

---

2.

`test/jdk/javax/sound/sampled/Lines/GetLine.java` has `SecurityManager` usage, is it covered by some other bug id?

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22371#pullrequestreview-2460104185


More information about the client-libs-dev mailing list