RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v4]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Nov 26 08:41:47 UTC 2024
On Mon, 25 Nov 2024 05:26:07 GMT, Tejesh R <tr at openjdk.org> wrote:
>> The test is supposed to be problem listed on macos & Linux but the Problem list points to the .java file instead of the .html file.
>> Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which would automatically resolve the issue.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated review comments
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line 26:
> 24: import java.awt.Frame;
> 25: import java.awt.Panel;
> 26: import java.awt.GridLayout;
Suggestion:
import java.awt.GridLayout;
import java.awt.Panel;
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line 60:
> 58: .title("Test Instructions")
> 59: .instructions(INSTRUCTIONS)
> 60: .rows((int) INSTRUCTIONS.lines().count() + 2)
not required anymore.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1858043482
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1858045022
More information about the client-libs-dev
mailing list