RFR: 8345004: Backout fix for JDK-8226990
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Nov 27 04:33:39 UTC 2024
On Tue, 26 Nov 2024 05:22:59 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
> The fix for [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) causes regression in dark theme for GTK L&F on Ubuntu system and that results in manual test failures identified recently.
>
> Few of the changes made in [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) is further modified in [JDK-8335130](https://bugs.openjdk.org/browse/JDK-8335130).
>
> Backing out the overall fix to prevent any regression.
>
> CI testing after revert is fine.
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 149:
> 147: @Override
> 148: protected void installDefaults() {
> 149: updateStyle(tabPane);
guess you missed adding this back
tabsOpaque = UIManager.getBoolean("TabbedPane.tabsOpaque");
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 640:
> 638: }
> 639:
> 640: tabContext.getPainter().paintTabbedPaneTabBackground(tabContext, g,
and this
if (tabsOpaque || tabPane.isOpaque()) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859866525
PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859867678
More information about the client-libs-dev
mailing list