RFR: 8345004: Backout fix for JDK-8226990

Abhishek Kumar abhiscxk at openjdk.org
Wed Nov 27 04:33:39 UTC 2024


On Wed, 27 Nov 2024 04:28:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 149:
>> 
>>> 147:     @Override
>>> 148:     protected void installDefaults() {
>>> 149:         updateStyle(tabPane);
>> 
>> guess you missed adding this back
>> tabsOpaque = UIManager.getBoolean("TabbedPane.tabsOpaque");
>
> ok..I guess I am wrong..

Not actually... `tabsOpaque` property was added in JDK-8226990 but later on it it is moved to SynthPainterImpl and GTKPainter classes under [JDK-8335130](https://bugs.openjdk.org/browse/JDK-8335130) issue.

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 640:
>> 
>>> 638:         }
>>> 639: 
>>> 640:         tabContext.getPainter().paintTabbedPaneTabBackground(tabContext, g,
>> 
>> and this
>> if (tabsOpaque || tabPane.isOpaque()) {
>
> it is not needed

same reason as above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859878196
PR Review Comment: https://git.openjdk.org/jdk/pull/22379#discussion_r1859880162


More information about the client-libs-dev mailing list