RFR: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard [v2]
Damon Nguyen
dnguyen at openjdk.org
Thu Nov 28 01:19:36 UTC 2024
On Wed, 27 Nov 2024 20:37:26 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - String comparison
>> - Review comments
>
> test/jdk/java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java line 131:
>
>> 129: // Press Down key to select next item in the choice(Motif 2.1)
>> 130: // If bug exists we won't be able to do so
>> 131: robot.keyPress(KeyEvent.VK_DOWN);
>
> delay on line 145 should be moved into the if-statement above it to prevent useless extra delay on non-mac systems
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22333#discussion_r1861394012
More information about the client-libs-dev
mailing list