RFR: 8345142: Remove uses of SecurityManager in Printing related classes [v2]

Phil Race prr at openjdk.org
Sat Nov 30 03:55:51 UTC 2024


On Thu, 28 Nov 2024 13:33:18 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8345142
>
> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 1658:
> 
>> 1656:                                        dest);
>> 1657:         } catch (SecurityException se) {
>> 1658:             //There is already file read/write access so at this point
> 
> Few other comments seems obsolete now
> 
> line 948:
> 
> 
> /* A security check has already been performed in the
>  * java.awt.print.printerJob.getPrinterJob method.
>  * So by the time we get here, it is OK for the current thread
>  * to print either to a file (from a Dialog we control!) or
>  * to a chosen printer.
>  *
>  * We raise privilege when we put up the dialog, to avoid
>  * the "warning applet window" banner.
>  */
> 
> (Same for the `PSPrinterJob.java:508`)
> 
> 
> line 1809:
> 
>      * The caller must have security permission to read system properties.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22422#discussion_r1864067011


More information about the client-libs-dev mailing list