RFR: 8341191: Open source few more AWT FileDialog tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Tue Oct 1 10:18:25 UTC 2024


On Tue, 1 Oct 2024 09:51:15 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing and removed unused code
>
> Marked as reviewed by psadhukhan (Reviewer).

@prsadhuk Please re-review.

> test/jdk/java/awt/FileDialog/SavedDirInitTest.java line 31:
> 
>> 29: import java.awt.event.ActionListener;
>> 30: 
>> 31: import java.awt.Component;
> 
> Component should be after Button..

Actually I was trying to automate the test and import was added, forgot to remove them after that.

Removed the import now.

> test/jdk/java/awt/FileDialog/SavedDirInitTest.java line 76:
> 
>> 74:                 }
>> 75:                 System.out.println("fd components count: "+fd.getComponentCount());
>> 76:                 System.out.println("fd components: "+fd.getComponents());
> 
> guess these also could be put in PassFailJFrame.log

Not used, removed now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21277#issuecomment-2385387028
PR Review Comment: https://git.openjdk.org/jdk/pull/21277#discussion_r1782507602
PR Review Comment: https://git.openjdk.org/jdk/pull/21277#discussion_r1782507974


More information about the client-libs-dev mailing list