RFR: 8341000: Open source some of the AWT Window tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Tue Oct 1 10:42:37 UTC 2024


On Tue, 1 Oct 2024 10:12:20 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Clean up and open source some of the AWT window tests.
>> Automated test `InvalidFocusLostEventTest.java` is verified in our CI also and it passes on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update for review comments

test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 47:

> 45:     private KeyboardFocusManager fm;
> 46: 
> 47:     static boolean failed = false;

should be Volatile ?

test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 57:

> 55:             if (f != null) {
> 56:                 f.dispose();
> 57:             }

should be disposed on EDT.

test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 79:

> 77:         robot.setAutoDelay(100);
> 78:         robot.setAutoWaitForIdle(true);
> 79:         Point bp = b.getLocationOnScreen();

should be on EDT.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1782540234
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1782538744
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1782538963


More information about the client-libs-dev mailing list