RFR: JDK-8340555 : Open source DnD tests - Set4 [v5]

Alexey Ivanov aivanov at openjdk.org
Tue Oct 1 20:38:36 UTC 2024


On Mon, 30 Sep 2024 14:32:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed redundant frame.setLocation()
>
> test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 60:
> 
>> 58: 
>> 59:                 If on multi-monitor screens then please position
>> 60:                 the drag and drop windows on different screens.
> 
> This can be done automatically… I mean `PassFailJFrame` won't be able to handle positioning of the second frame on another screen. Yet you can do it in the code.

I wanted to add a comment that these enhancements could be implemented later because *“they're out of scope”* of converting applet tests.

At the same, it could be easier to do it while working on a test; returning to it later would require additional time to understand what needs to be done. But I agree additional features add up and eat time.

So, submitting bugs for additional improvements is a good balance. Otherwise, no one will ever remember.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1783502275


More information about the client-libs-dev mailing list