RFR: 8341000: Open source some of the AWT Window tests [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Thu Oct 3 07:43:36 UTC 2024
On Thu, 3 Oct 2024 07:33:16 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Clean up and open source some of the AWT window tests.
>> Automated test `InvalidFocusLostEventTest.java` is verified in our CI also and it passes on all platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>
> Update based on review comments
test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 60:
> 58: countDownLatch.await();
> 59: if (fm.getFocusOwner() != b) {
> 60: failed = true;
I guess exception can be thrown here and then no need of `failed` variable and checking from finally block can be removed.
test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java line 90:
> 88: robot.setAutoWaitForIdle(true);
> 89: EventQueue.invokeAndWait(() -> bp = b.getLocationOnScreen());
> 90: robot.mouseMove(bp.x + b.getWidth() / 2, bp.y + b.getHeight() / 2 );
button width and height should be accessed on EDT?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785771608
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785772235
More information about the client-libs-dev
mailing list